SSL_connect: incorrect use of return value in securesocket

Description

In system/security/securesocket/securesocket.cpp (see code below), 'if(err < 0)' should be 'if(err <= 0)'. See SSL_connect return values: https://www.openssl.org/docs/ssl/SSL_connect.html.

CSecureSocket::secure_connect()
{
int err = SSL_connect (m_ssl);
if(err < 0)
{
....

Conclusion

None

Activity

Show:

Russ Whitehead November 21, 2014 at 1:26 PM

This is ready to be merged

Lorraine Chapman November 5, 2014 at 1:01 PM

says there is some new code around here that should be checked out for 5.0.4, but will move to 5.2 if necessary

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Components

Assignee

Reporter

Priority

Fix versions

Pull Request URL

Created October 23, 2014 at 7:32 PM
Updated November 24, 2014 at 10:34 AM
Resolved November 24, 2014 at 10:34 AM