Scope checking of workunit lists defeats lazy fetch

Description

From inspection of the code, it looks like the scope checking of a list of workunits is done by gather all the scopes of all workunits in the list up front, in order to check each scope only once. However, this will mean that the way the list is implemented as a lazy iterator is defeated when scope checking is enabled.

Conclusion

None

Activity

Show:

Richard Chapman June 10, 2015 at 7:10 AM

I'm doing a lot of work in this area that may well result in the entire code changing here. So I'll take care of this as I go.

Richard Chapman June 9, 2015 at 2:30 PM

In workunit.cpp, there is the following code:

When secmgr is NULL, workunits will be read from dali only when the consumer of the iterator reads them. But if secmgr is not NULL, and the above code is executed, there is an additional pass through all the workunits to create the list of scopes.

Russ Whitehead June 9, 2015 at 2:06 PM

Please elaborate, not sure what you mean. Also, for reference, where in the code are you looking?

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Components

Assignee

Reporter

Priority

Fix versions

Pull Request URL

Created May 28, 2015 at 9:29 AM
Updated June 29, 2015 at 7:26 AM
Resolved June 29, 2015 at 7:26 AM