Remove './' from the target path generated by the new ECLWatch.

Description

I think that is a bug in new ECLWatch. In legacy ECLWatch, the full path is shown on UI dialog and is sent to ESP. But, in new ECLWatch dialog, relative path '.' is shown. And the dialog code just appends the relative path to drop zone path and sends the result to ESP. Since there is no harm, the problem has not been noticed and fixed.
However in the fix of the parent issue () will be rejecting paths containing any './' or '../'.

Conclusion

None

Activity

Show:

Miguel Vazquez March 9, 2016 at 9:31 PM

FYI for code review purposes.

Attila Vamos March 9, 2016 at 9:13 PM

Despray will no accept target file name with '/./' or '/../' in it. Any other target file name will be check to point inside a drop zone.
So If a target filename path begins with /var/lib/HPCC/dropzonedir (or any other drop zone path, defined in the environment.xml) then it would be fine.

Miguel Vazquez March 9, 2016 at 3:06 AM
Edited

So despray will accept no value as its default? Or /var/lib/HPCC/dropzonedir ?

Miguel Vazquez February 23, 2016 at 2:39 PM
Edited

Lets align this with whatever fix version parent issue.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Components

Assignee

Reporter

Priority

Fix versions

Pull Request URL

Created February 23, 2016 at 1:48 PM
Updated March 29, 2016 at 9:07 AM
Resolved March 29, 2016 at 9:07 AM