Unsafe code in tokenserializer.hpp

Description

Spotted this code when looking at something else:

ptr here is (I assume) a null-terminated string - no length information is being passed - but there is no check that it points to a string of at least 4 characters here. Were ptr to point to a string of less than 4 chars that happened to be at the end of a page, this code would segfault.

Conclusion

None

Activity

Show:

Richard Chapman June 2, 2017 at 11:28 AM

Use strnicmp

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Components

Assignee

Reporter

Priority

Fix versions

Pull Request URL

Affects versions

Created April 12, 2017 at 7:56 AM
Updated June 5, 2017 at 8:47 AM
Resolved June 5, 2017 at 8:47 AM