Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Two different ways of providing WuPropertyTypes causing confusion

Description

IConstWUScopeIterator::playProperties has first argument as WuPropertyTypes.  This is causing some confusion as the WuScopeFilter may also have WuPropertyTypes to be set (through a call to WuScopeFilter::addOutputProperties). WuPropertyTypes may be set in 2 different locations, potentially to 2 different inconsistant values.

e.g.

wuScopeFilter.addOutputProperties(PTall);

Owned<IConstWUScopeIterator> iter = &workunit->getScopeIterator(wuScopeFilter);
ForEach(*iter)
{
    iter->playProperties(PTstatistics, wuDetailsVisitor);

....

 Is it possible to remove the WuPropertyTypes parameter from playProperties?

Conclusion

None

Activity

Show:

Gavin Halliday October 27, 2017 at 10:24 AM

The correct use is to restrict the output in the filter - which allows the scope iterator to be optimized - and then use PTall on the play call.

I will move the argument to the end and make it optional.  (If specified it would allow a subset of the scope filter to be played.

 

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Components

Assignee

Reporter

Priority

Compatibility

Major

Fix versions

Pull Request URL

Created October 17, 2017 at 11:16 AM
Updated November 6, 2017 at 9:12 AM
Resolved November 6, 2017 at 9:12 AM