Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Create option to disable log_id

Description

While logging, the standard logging library forces a "log_id" field to be logged. This task aims to turn that optional.

Conclusion

None

Activity

Show:

Felipe Roscoche July 20, 2018 at 4:22 PM

Felipe Roscoche July 16, 2018 at 2:36 PM

Created the PR. The default behavior is to look for "enableLogID" flag in the Fieldmap, but it does not require this field to be there. It assumes as true, therefore not changing the default behavior which is always logging "log_id", unless explicitly told otherwise by the flag enableLogID="false".

Felipe Roscoche July 2, 2018 at 5:21 PM

In the logginglib, we have a line in "loggingagentbase.cpp" that forces log_id to be logged:

appendFieldInfo("log_id", logID, fields, values, true);

This goes directly in the INSERT statement, forcing the DB table that we want to log to have this field. The problem is that we do not want this field to be logged because we do not have this column in our tables. So the way out is to enable and option for that. I talked to Wang and a flag can be put inside each FieldMap. The solution I already implemented, just need to open the PR. Any questions let me know! Thanks

Richard Chapman July 2, 2018 at 1:55 PM

Not sure I really understand the request - can you provide more details of what you are asking for

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Components

Assignee

Reporter

Priority

Compatibility

Minor

Fix versions

Pull Request URL

https://github.com/hpcc-systems/HPCC-Platform/pull/11421
https://github.com/hpcc-systems/HPCC-Platform/pull/11421

Created June 22, 2018 at 3:29 PM
Updated July 20, 2018 at 4:22 PM
Resolved July 20, 2018 at 2:55 PM

Flag notifications