More build problems relating to static cryptohelper lib included in jlib

Description

The building of a static library (cryptohelper) and it's inclusion in a shared library (jlib), seems to have caused various problems, depending on the build environment.
In VC2015 it caused 'multiple definitions of' errors - but these did not occur in a VS2017 setup.
In Ubuntu 14.04 - it caused various 'missing symbol' errors (missing openssl symbols referenced by cryptohelper), but these did not appear in Ubuntu >=16.04 or CentOS distros.

It has also caused some issues (previously fixed) with symbol visibility requiring the need for /WHOLEARCHIVE / --whole-archive to be used.

Conclusion

None

Activity

Show:

Jacob Cobbett-Smith September 11, 2018 at 4:45 PM

Am going to fix by avoiding using a static library here and instead include the sources directly in the jlib cmake file.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Components

Assignee

Reporter

Priority

Compatibility

Point

Fix versions

Pull Request URL

Created September 11, 2018 at 4:44 PM
Updated September 12, 2018 at 2:43 PM
Resolved September 12, 2018 at 2:37 PM