Build error on master in release mode

Description

In member function 'void CEsdlCustomTransform::verifyPrefixDeclared(IPropertyTree&, const char*)',
4494
inlined from 'CEsdlCustomTransform::CEsdlCustomTransform(IPropertyTree&, const char*)' at /hpcc-dev/HPCC-Platform/esp/esdllib/esdl_script.cpp:695:41:
4495
/hpcc-dev/HPCC-Platform/esp/esdllib/esdl_script.cpp:680:38: error: '%s' directive argument is null [-Werror=format-overflow=]
4496
680 | throw MakeStringException(ESDL_SCRIPT_Error, "Undeclared script xmlns prefix %s", prefix);
4497
cc1plus: some warnings being treated as errors
4498
make[2]: *** [esp/esdllib/CMakeFiles/esdllib.dir/build.make:102: esp/esdllib/CMakeFiles/esdllib.dir/esdl_script.cpp.o] Error 1
4499
make[1]: *** [CMakeFiles/Makefile2:12343: esp/esdllib/CMakeFiles/esdllib.dir/all] Error 2
4500
make[1]: *** Waiting for unfinished jobs....
4501

Conclusion

None

Activity

Show:

Anthony Fishbeck May 6, 2020 at 2:08 PM

I thought we actually handled nulls in our MakeStringException %s handling. 

In any case, the reason the compiler is complaining is probably when I explicitly pass a null in one call to this function.

I'll add explicit null handling.

Richard Chapman May 6, 2020 at 10:40 AM

Actually not really sure what this code is doing.

Richard Chapman May 6, 2020 at 9:23 AM

I suspect the parameter on line 680 was supposed to be "uri"

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Components

Assignee

Reporter

Priority

Compatibility

Point

Fix versions

Pull Request URL

Roadmap

Not applicable

Affects versions

Created May 6, 2020 at 9:23 AM
Updated May 6, 2020 at 2:50 PM
Resolved May 6, 2020 at 2:50 PM