Thor Slave not starting

Description

Buckle up...

Note: I believe more versions are affected by this.

I'm on Ubuntu 20.04 and build source code based on tag community_8.4.2-1 (available here: https://github.com/lpezet/HPCC-Platform/tree/community_8.4.2-1-lpezet)

 

After fixing a couple other small things, I'm still not able to get the Thor Slave to start.

I install the package and simply run:

I don't see any thorslave_lcr (that's what I'm expecting, but please correct me if I'm wrong):

I see log file /var/log/HPCCSystems/mythor/thorslaves-launch.debug was created, and its content is:

 

For testing purposes here, I believe we can just do:

Now /opt/HPCCSystems/sbin/thorslaves-exec.sh has many things going on and here is a comment.
It checks that a couple of directories exist, BUT it will create those without "sudo" and I believe it would fail since parent directories are root only (e.g. /var/log, /var/run).
It then creates a configuration file in /var/lib/HPCCSystems/thorslaves and finally run:

(which ends up being "sudo systemctl start thorslave@thorslave_mythor_1.service").

Which fails:

 

Now I was fiddling with thslavemain.cpp and I believe it's exiting because parameters are not passed properly.
This is what's being called in the end:

I believe this is what it should be:

(notice the "–" before each argument name)

 

This seems to be a recurring pattern with HPCC-26757.

Conclusion

None

Activity

Show:

Michael Gardner November 1, 2021 at 12:51 AM

The reason this is happening is a change to how we included globals. I think it goes back as far as 7.8. Commit can be found here https://github.com/hpcc-systems/HPCC-Platform/commit/bd9e704545aa29ec05265b4c0363492c7f08ec22#diff-6095418795f3a03d23c0932453ccb5821ce8b11029717e8cdb861924cfe835a5

I've tested adding – to the parmeters and it properly loads the globals in and doesn't throw usage() and error out after trying to load the first "master" argument.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Components

Assignee

Reporter

Priority

Compatibility

Point

Pull Request URL

Roadmap

Not applicable

Affects versions

Created October 30, 2021 at 3:00 AM
Updated November 1, 2021 at 4:56 PM
Resolved November 1, 2021 at 4:56 PM