Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Coverity scan reported new defects related to ESDL.

Environment

OBT Coverity Scan

Description

The reported problem is:

*** CID 1535263:  Control flow issues  (DEADCODE) /home/centos/build/CE/platform/HPCC-Platform/esp/esdllib/esdl_script.cpp: 2393 in createEsdlTransformOperations(IArrayOf<IEsdlTransformOperation> &, xpp::IXmlPullParser &, const StringBuffer &, bool, IEsdlOperationTraceMessenger &, IEsdlFunctionRegister *)() 2387                     if (operation) 2388                         operations.append(*operation.getClear()); 2389                     break; 2390                 } 2391                 case XmlPullParser::END_TAG: 2392                     return; >>>     CID 1535263:  Control flow issues  (DEADCODE) >>>     Execution cannot reach this statement: "case xpp::IXmlPullParser::E...". 2393                 case XmlPullParser::END_DOCUMENT: 2394                     return; 2395             } 2396         } 2397     } 2398

 

To view the defects in Coverity Scan visit, https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fu15810271.ct.sendgrid.net%2Fls%2Fclick%3Fupn%3DHRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypQjb0hTUkvcp9raSmREwFq6YYouACn74NAOJog3t-2B9hwML-2BjS1JaRteOgFFK87Rag-3Dj6oL_8MqIhCRnGbt-2F8erpzfaQPKt49wIYlz1MQCVtEp8qAdFLL5nn5nscv97zvRUlUFy1RyucpQMHgdkp0IOUAJAa0vc7B7lFaMffOCmvap2M17vbPPB1yuNu73xceAOyDUqfKKxKBrMlYVPgyV1mtxvWK7JPPg6g3pH9q8AVGBTWsMKVcMc3bZZLjoBMZLXW9r1FbSQBq3ChMT07sXt5D4S2bRbTu-2FQTl1x7GmY-2Fna4ImIM-3D&data=05%7C01%7Cattila.vamos%40lexisnexis.com%7C676dcd6c3e5649f2b79608db188f4f4a%7C9274ee3f94254109a27f9fb15c10675d%7C0%7C0%7C638130776019885889%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eD%2Bs6zqK5rXLXEebfqTdltgjV1rA0CKLXf6JniUgVdM%3D&reserved=0

 

Conclusion

None

Activity

Show:

Tim Klemm February 27, 2023 at 4:57 PM

This code has been unreachable for 3 years (since its initial commit). The loop condition making it unreachable also makes it redundant. It can safely be removed.

Anthony Fishbeck February 27, 2023 at 2:59 PM

might have been a side effect of some recently merged esdl_script change.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Components

Assignee

Reporter

Priority

Compatibility

Minor

Fix versions

Pull Request URL

https://github.com/hpcc-systems/HPCC-Platform/pull/17013
https://github.com/hpcc-systems/HPCC-Platform/pull/17013

Roadmap

Not applicable

Affects versions

Created February 27, 2023 at 2:42 PM
Updated March 14, 2023 at 1:40 PM
Resolved March 14, 2023 at 1:40 PM

Flag notifications