macOS 13 build break in mpcomm.cpp

Description

/Users/runner/work/HPCC-Platform/HPCC-Platform/HPCC-Platform/system/mp/mpcomm.cpp:228:110: error: field 'endpoint' will be initialized after field 'msg' [-Werror,-Wreorder-ctor]

915 CMPException(MessagePassingError err,const SocketEndpoint &ep, const char *_msg = nullptr) : error(err), endpoint(ep), msg(_msg)

916 ~~~~~~~~~~ ^~~~~~~~~~~~ ~~~~~~~~~

917 msg(_msg) error(err) endpoint(ep)

918

I know it has been recommended to initialize member values in the order they are declared. The Apple compiler now seems to require it by default.

Conclusion

None

Activity

Show:

Gavin Halliday October 22, 2024 at 12:03 PM

This warning has been enabled, and flagged as an error in 9.10.x builds. This means that new code applied to 9.8.x and 9.6.x will occasionally fall foul of the checking in master when it is upmerged. It should not be much of an ongoing problem.

HPCC JiraBot October 22, 2024 at 12:02 PM

Jirabot Action Result:
Fix versions already added.

HPCC JiraBot October 21, 2024 at 3:48 PM

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Components

Assignee

Reporter

Priority

Fix versions

Pull Request URL

Created October 21, 2024 at 3:21 PM
Updated January 15, 2025 at 4:10 PM
Resolved October 22, 2024 at 12:01 PM